Skip to content

refactor(preview): remove deprecated PreviewManager::registerProvider API#59905

Merged
nickvergessen merged 3 commits into
masterfrom
jtr/chore-drop-registerProvider-IPreview
Jun 9, 2026
Merged

refactor(preview): remove deprecated PreviewManager::registerProvider API#59905
nickvergessen merged 3 commits into
masterfrom
jtr/chore-drop-registerProvider-IPreview

Conversation

@joshtrichards

@joshtrichards joshtrichards commented Apr 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

🧹

Summary

  • remove the deprecated public PreviewManager::registerProvider() API
  • replace it with a private internal helper for provider registration
  • update internal core and bootstrap provider registration to use the new helper
  • add an explicit return type to the core provider closure for consistency with bootstrap provider registration

Notes:

  • keeps the existing provider registration behavior unchanged
  • reduces public API surface

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@joshtrichards joshtrichards added this to the Nextcloud 34 milestone Apr 24, 2026
@joshtrichards joshtrichards changed the title refactor(preview): remove deprecated PreviewManager::registerProvider API refactor(preview): remove deprecated PreviewManager::registerProvider API Apr 24, 2026
@joshtrichards joshtrichards force-pushed the jtr/chore-drop-registerProvider-IPreview branch from e952d51 to 8e43019 Compare April 25, 2026 15:48
@joshtrichards joshtrichards added the 3. to review Waiting for reviews label Apr 25, 2026
@joshtrichards joshtrichards marked this pull request as ready for review April 25, 2026 15:48
@joshtrichards joshtrichards requested a review from a team as a code owner April 25, 2026 15:48
@joshtrichards joshtrichards requested review from CarlSchwan, leftybournes, provokateurin and salmart-dev and removed request for a team April 25, 2026 15:49
@CarlSchwan CarlSchwan added the pending documentation This pull request needs an associated documentation update label May 11, 2026
@joshtrichards @CarlSchwan
chore(previews): drop long deprecated registerProvider from IPreview
07bac53 
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards @CarlSchwan
chore(previews): registerProvider->registerProviderClosure in Preview…
bf9d97e 
…Manager

No longer part of the public interface. Just an internal utility function.

Apps/etc register in other ways and still end up here appropriately.

Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards @CarlSchwan
chore(previews): let psalm know about $class typing
3c1cf25 
Signed-off-by: Josh <josh.t.richards@gmail.com>
@CarlSchwan CarlSchwan force-pushed the jtr/chore-drop-registerProvider-IPreview branch from 8e43019 to 3c1cf25 Compare May 11, 2026 11:10
@nextcloud-bot nextcloud-bot mentioned this pull request May 27, 2026
Merged
@nextcloud-bot nextcloud-bot mentioned this pull request Jun 4, 2026
Closed
@skjnldsv skjnldsv mentioned this pull request Jun 4, 2026
Merged
This was referenced Jun 5, 2026
Merged
Merged
@susnux susnux added the community pull requests from community label Jun 9, 2026
@nickvergessen nickvergessen merged commit 4700c85 into master Jun 9, 2026
191 of 200 checks passed
@nickvergessen nickvergessen deleted the jtr/chore-drop-registerProvider-IPreview branch June 9, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@provokateurin provokateurin provokateurin approved these changes

@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews community pull requests from community feature: previews and thumbnails pending documentation This pull request needs an associated documentation update technical debt 🧱 🤔🚀

Projects

None yet

Milestone

Nextcloud 35

Development

Successfully merging this pull request may close these issues.

6 participants

@joshtrichards @CarlSchwan @provokateurin @nickvergessen @susnux @nextcloud-bot